feat: monadic defs for statically sized vectors #925
Conversation
|
WIP |
| def modifyM [Monad m] (v : Vector α n) (i : Nat) | ||
| (f : α → m α) : m (Vector α n) := do | ||
| return ⟨←Array.modifyM v.toArray i f, | ||
| by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
Any help in fixing this sorry is welcome. I found a lemma by the name Array.size_modifyM which however is not a straightforward equality.
| -/ | ||
| def mapM {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] | ||
| (f : α → m β) (v : Vector α n) : m (Vector β n) := do | ||
| return ⟨←Array.mapM f v.toArray, by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
This sorry is also stuck for the same reason as the above comment because the corresponding Array API uses Satisfies. I am grateful for any help with these situations
| def mapIdxM {α : Type u} {β : Type v} {m : Type v → Type w} [Monad m] | ||
| (v : Vector α n) (f : Fin n → α → m β) : m (Vector β n) := do | ||
| return ⟨←Array.mapIdxM v.toArray (v.size_eq.symm ▸ f), | ||
| by rw[←v.size_eq]; sorry⟩ |
There was a problem hiding this comment.
Another sorry that I am stuck at because the relevant API lemma uses the Satisfies predicate.
|
Most of these have since been implemented upstream. I'm going to close now, but if you'd like to open a PR filling any remaining gaps, that would be great. See https://github.com/leanprover/lean4/blob/master/tests/lean/run/list_monadic_functions.lean for a map of the current implementation status. |
|
@kim-em : the defs |
|
Ok, if those are ready could you open a new PR containing just those? |
|
This PR is the first follow up to #793. It adds all the monadic definitions for Vectors that correspond to similar definitions for Arrays in core and Batteries as well as defs which are immediately downstream of them. There are no plans to add theorems in this PR.
-[] Add all monadic definitions from
Init.Data.Array.Basicand their downstream definitions for Vectors.-[] Add all monadic definitions from
Batteries.Data.Array.Basicand their downstream definitions for Vectors.