Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function for refl and apply #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcdoll
Copy link
Member

@mcdoll mcdoll commented May 24, 2023

No description provided.

@kim-em kim-em added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 21, 2023
@kim-em kim-em added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Sep 4, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 19, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Mar 5, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label May 7, 2024
@fgdorais
Copy link
Collaborator

Heartbeat check: is this PR still active? If it is then just give a thumbs up and I will delete this comment.

@kmill
Copy link
Contributor

kmill commented Jul 22, 2024

The apply function is in core now as Lean.MVarId.applyConst, but I don't think refl? exists in core.

Comment on lines +281 to +284
/-- Apply a lemma with fresh metavariable levels. -/
def applyWithFreshMVarLevels (mvarId : MVarId) (lemmaName : Name) :
MetaM (List MVarId) := mvarId.withContext do
mvarId.apply (← mkConstWithFreshMVarLevels lemmaName)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in Lean core as Lean.MVarId.applyConst

Suggested change
/-- Apply a lemma with fresh metavariable levels. -/
def applyWithFreshMVarLevels (mvarId : MVarId) (lemmaName : Name) :
MetaM (List MVarId) := mvarId.withContext do
mvarId.apply (← mkConstWithFreshMVarLevels lemmaName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author Waiting for PR author to address issues merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants