Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Array windows and chunks API from Rust #126

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Array windows and chunks API from Rust #126

wants to merge 6 commits into from

Conversation

hargoniX
Copy link
Collaborator

Right now without the respective reverse chunks functions to check if this API design is fine before doing it wrong twice.

@kim-em kim-em added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Aug 21, 2023
@joehendrix
Copy link
Contributor

Are there other projects using this? I think we are potentially better served more abstract than this in Std, but I'm not quite sure how this is used.

@joehendrix joehendrix added awaiting-author Waiting for PR author to address issues and removed awaiting-review This PR is ready for review; the author thinks it is ready to be merged. labels Oct 26, 2023
@hargoniX
Copy link
Collaborator Author

This PR (like my other Array based one) was inspired by the Rust API functions for Vec (https://doc.rust-lang.org/stable/std/vec/struct.Vec.html) since Lean often tends to copy Rust functionality I thought it might be a good idea to put it into our stdlib as well.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Nov 15, 2023
@fgdorais
Copy link
Collaborator

Heartbeat check: is this PR still active? If it is then just give a thumbs up and I will delete this comment.

@hargoniX
Copy link
Collaborator Author

I'm not going to invest more time in it.

@fgdorais fgdorais added help wanted Extra attention is needed and removed awaiting-author Waiting for PR author to address issues labels Jul 23, 2024
@fgdorais
Copy link
Collaborator

Understood. I'm removing awaiting-author and adding help-wanted to signal that this PR is "for adoption".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hargoniX @joehendrix @fgdorais @kim-em @leanprover-community-mathlib4-bot @digama0