Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sum.left, Sum.right #105

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JamesGallicchio
Copy link
Collaborator

More intuitive names than .inl and .inr for non-type-theorists.

See https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/No.20Either.20type

@JamesGallicchio JamesGallicchio changed the title feat: Sum.inl, Sum.inr feat: Sum.left, Sum.right Mar 5, 2023
@JamesGallicchio
Copy link
Collaborator Author

do these definitions need any of reducible, inline, always_inline?

@digama0
Copy link
Member

digama0 commented Mar 5, 2023

if you use abbrev they will get reducible, inline

@eric-wieser
Copy link
Member

eric-wieser commented Mar 5, 2023

It's possibly a bit confusing that prod.left is a projection but Sum.left and Or.intro_left are constructors.

@JamesGallicchio JamesGallicchio marked this pull request as draft June 27, 2023 05:16
@kim-em kim-em added the WIP work in progress label Aug 8, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Aug 21, 2023
@fgdorais
Copy link
Collaborator

This WIP PR has been inactive for over a year. Should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants