Skip to content

Require tactic clauses to be indented #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLimperg merged 3 commits into from
Dec 6, 2025
Merged

Require tactic clauses to be indented #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cccb295
add ppSpace colGt in syntax
alexb-harmonic Nov 28, 2025
d2b1b15
add test
alexb-harmonic Dec 1, 2025
765bb3d
Fix test and move to separate file
JLimperg Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Aesop/Frontend/Tactic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ clauses are:
`(simp_config := { zeta := false })` makes Aesop use
`simp (config := { zeta := false })`.
-/
syntax (name := aesopTactic) "aesop" Aesop.tactic_clause* : tactic
syntax (name := aesopTactic) "aesop" (ppSpace colGt Aesop.tactic_clause)* : tactic

@[inherit_doc aesopTactic]
syntax (name := aesopTactic?) "aesop?" Aesop.tactic_clause* : tactic
syntax (name := aesopTactic?) "aesop?" (ppSpace colGt Aesop.tactic_clause)* : tactic

meta initialize do
Batteries.Linter.UnreachableTactic.addIgnoreTacticKind ``aesopTactic
Expand Down
22 changes: 22 additions & 0 deletions AesopTest/Indent.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/-
Copyright (c) 2025 Alex Best. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Alex Best, Jannis Limperg
-/

import Aesop

/-! Test case for clause indentation. We require Aesop tactic clauses to be on
the same line or indented, to prevent Aesop from mistaking the following
tactics for clauses. -/

example : ∃ n : Nat, n ^ 2 = 4 ∧ ∃ n : Nat, n ^ 2 = 9 ∧ True := by
aesop
(config := { maxRuleApplications := 1, warnOnNonterminal := false })
(exists 2)
(exists 3)

example : ∃ n : Nat, n ^ 2 = 4 ∧ ∃ n : Nat, n ^ 2 = 9 ∧ True := by
aesop (config := { maxRuleApplications := 1, warnOnNonterminal := false })
(exists 2)
(exists 3)