Remove unused leafs/http dependency to clean up project - #56
Open
fadrian06 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved review issues were identified.
Pull request overview
Removes the unused leafs/http dependency from leafs/auth.
Changes:
- Deletes
leafs/httpfrom Composer requirements. - Retains other authentication dependencies.
File summaries
| File | Summary |
|---|---|
composer.json |
Removes the unnecessary HTTP dependency. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Developers using
leafs/authwithoutleafs/leafare still installingleafs/httpunnecessarily, the Request, Response and Pages objects are only used if the developer hasleafs/leafinstalled.This pull request is part of a series of cleanups made by me to reduce the size of the
leafs/authpackage and reduce installation timesDescription
This pull request makes a minor update to the project's dependencies by removing the
leafs/httppackage fromcomposer.json. This change reduces unused or unnecessary dependencies in the project.Does this PR introduce a breaking change? (check one)
This change will only break projects that use
leafs/httpwithout requiring it incomposer.json, relying on it being included withleafs/auth.If this pull request manages to be integrated into version 5, developers should be notified that
leafs/authno longer includesleafs/http, so if you use that package in your projects, add it to therequires ofcomposer.json