Skip to content

feat: update deps and bundle app #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewis6991
Copy link

@lewis6991 lewis6991 commented May 29, 2025

  • actions/cache: 3.1.2 -> 4.0.3

  • actions/core: 1.2.6 -> 1.11.1

  • actions/exec: 1.0.4 -> 1.1.1

  • actions/io: 1.0.2 -> 1.1.3

  • actions/tool-cache: 2.0.1 -> 2.0.2

  • Specifically update actions/cache to v4 as the backends for v3 have now
    been retired.

  • Bundle action using esbuild and remove node_modules

    • I'd normally do this in a separate PR, but the dependency updates increased the size of node_modules substantially to the point that pushing this commit took a fair few seconds

@lewis6991
Copy link
Author

@lewis6991 lewis6991 force-pushed the master branch 4 times, most recently from 65acad0 to b2b0338 Compare May 29, 2025 21:57
- actions/cache: 3.1.2 -> 4.0.3
- actions/core: 1.2.6 -> 1.11.1
- actions/exec: 1.0.4 -> 1.1.1
- actions/io: 1.0.2 -> 1.1.3
- actions/tool-cache: 2.0.1 -> 2.0.2

- Specifically update actions/cache to v4 as the backends for v3 have now
  been retired.

- Bundle action using esbuild and remove node_modules
@lewis6991 lewis6991 changed the title feat: update deps feat: update deps and bundle app May 29, 2025
@BreakBB
Copy link

BreakBB commented May 30, 2025

Please @leafo merge this and ship a new release. Our pipeline time increased from ~3 minutes to ~20, because of the broken caching.

@Mctalian
Copy link

Fixes #57

@fernandes6502
Copy link

I'm also affected by this, pipelines are 15 min longer. Please merge this PR.

@Mctalian
Copy link

Mctalian commented Jun 7, 2025

I'm doing this while waiting for the official release:

      - uses: lewis6991/gh-actions-lua@01aab24c4de9555717b685f9b142a2abbe12ef14
        with:
          luaVersion: 5.3.5

Works like a charm, thanks @lewis6991 !

@BreakBB
Copy link

BreakBB commented Jun 8, 2025

We changed to this:

steps:
      - name: Install Lua
        run: |
          sudo apt-get install lua5.1 lua-check luarocks
          sudo luarocks install bit32
          sudo luarocks install busted

No extra action required and it's way faster.

@lewis6991
Copy link
Author

Do you have anything for windows?

@BreakBB
Copy link

BreakBB commented Jun 8, 2025

I don't have any Windows idea @lewis6991 if your question meant me. I currently don't use any Windows image in a CI environment 🤷 Not sure if WSL can be used, where the code I posted above might work.

@Muehe
Copy link

Muehe commented Jun 14, 2025

If you want to directly install Lua on a Windows host you might be able to use winget. Although not sure how or if version selection works there (note the install lua5.1 in the example above, which runs on a ubuntu-latest host).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants