fix(caddy): TLS certificates trust on all platforms#34
Merged
Conversation
aegypius
reviewed
Sep 23, 2024
Contributor
aegypius
left a comment
aegypius
left a comment
There was a problem hiding this comment.
praise: @lucasmirloup This is a great simplification. I think, I might have gone another way with the certificate storage (keep a volume, instead of writing a file to the system) but maybe this can be improved later by using a symlink to the volume instead of a copy
This approach will help caddy to renew its certificate without human intervention in the future.
setup.sh
Outdated
| docker compose cp proxy:/usr/bin/caddy /tmp/caddy 2>/dev/null | ||
|
|
||
| rm /tmp/caddy | ||
| /tmp/caddy trust |
Contributor
There was a problem hiding this comment.
question: Why removing the untrust before trusting a new one. It's was here to cleanup intermediary certificates ?
lucasmirloup
force-pushed
the
fix/caddy-tls-certificates-trust
branch
3 times, most recently
from
db8226f to
88676f6
Compare
thislg
approved these changes
Aug 4, 2025
thislg
force-pushed
the
fix/caddy-tls-certificates-trust
branch
from
88676f6 to
92fd235
Compare
thislg
force-pushed
the
fix/caddy-tls-certificates-trust
branch
from
017d29f to
1b62e0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.wrike.com/open.htm?id=1494735894