Skip to content

Move nested modules handling into a separate function #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

Thirumalai-Shaktivel
Copy link
Collaborator

Related: #992, #1305

@Thirumalai-Shaktivel Thirumalai-Shaktivel added ready for review PRs that are ready for review asr ASR related changes labels Nov 17, 2022
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thanks for fixing it!

Let's merge this after the sync.

To set the correct module name to be imported.
Also, set the correct import path
@certik
Copy link
Contributor

certik commented Nov 18, 2022

I rebased on top of the sync, let's see if everything passes. If so, we can merge.

@certik certik enabled auto-merge November 18, 2022 23:25
@certik certik merged commit 3064bad into lcompilers:main Nov 18, 2022
@Thirumalai-Shaktivel Thirumalai-Shaktivel deleted the nested_modules_02 branch November 19, 2022 02:46
@Thirumalai-Shaktivel
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asr ASR related changes ready for review PRs that are ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants