Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird placeholder margin #1250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lagartoverde
Copy link
Contributor

Overview

There's a style that sets the right margin of mark-highlight-manual (the old class for placeholder) so it seems like after that node there are 2 spaces instead of 1, I fixed this using our new class for placeholder to minimize the impact on other places, as this class is used a lot in our apps

connected issues and PRs:

GN-5445 (maybe?)

Setup

None

How to test/reproduce

Insert a placeholder and notice the margin right is reduced to a normal amount

Challenges/uncertainties

Maybe is just better to remove it from the class

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma
Copy link
Contributor

We should probably look at removing the mark-highlight-manual class altogether, and include its relevant styles on the say-placeholder class.

@lagartoverde
Copy link
Contributor Author

Yeah but that would be a breaking release, and I wanted to do a patch :P.
Maybe something to include in a future issue

@elpoelma
Copy link
Contributor

Yeah but that would be a breaking release, and I wanted to do a patch :P. Maybe something to include in a future issue

That's fair, you'll need to target and older release then however, as the current slated release will be breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants