Add option to configure editor as non-editable

[elpoelma]

Overview

This PR adds an option to configure the editor as non-editable.
It can be configured in two ways:

• Using the ember Editor component, by passing the editable argument. The editor will also correctly react to value changes of this argument.
• Using an instance of the SayController class, by executing the toggleEditable method

How to test/reproduce

• Start the test-app
• Open the index page
• Test out the toggle editable button. This button uses the Editor component argument approach
• The toggleEditable method of the editor controller should yield the same results.

Challenges/uncertainties

• The toolbar/sidebar do not react to the editability of the document. At the moment, they should be configured to be enabled/disabled by the user of this addon.
• Unsure if it is useful to keep both pathways to configure the editability of a document (controller vs component argument)

Checks PR readiness

• UI: works on smaller screen sizes
• UI: feedback for any loading/error states
• Check cancel/go-back flows
• Check database state correct when deleting/updating (especially regarding relationships)
• changelog
• npm lint
• no new deprecations

[lagartoverde]

Works correctly, seems like it takes some time to make it editable again, but I guess the use of this is not to make editable/not editable quickly

[lagartoverde]

you can do !!this.editable I think

[elpoelma]

Not in this case I think, as we do not want to trigger it when editable is undefined or null, this is why we strictly compare it to false.

[abeforgit]

I'm missing also the visual changes we do in GN (placeholders from yellow to grey, etc)

I think we should try to make it as ootb as possible, requiring no extra css from embeddable users until they specifically ask for customization

[abeforgit]

With that said, we might even want to hide the toolbar and sidebar as well with this toggle

[elpoelma]

With that said, we might even want to hide the toolbar and sidebar as well with this toggle

I'm not sure if that is the responsibility of this addon? As the user can configure themselves whether to show the sidebar and toolbar, essentially this addon does not have control over their visibility. We can however, control that visibility in the embeddable package.

[elpoelma]

I'm missing also the visual changes we do in GN (placeholders from yellow to grey, etc)

I think we should try to make it as ootb as possible, requiring no extra css from embeddable users until they specifically ask for customization

Agreed, will look into adapting the css. We might then also have to do some adaptions of the plugins css.

[abeforgit]

With that said, we might even want to hide the toolbar and sidebar as well with this toggle

I'm not sure if that is the responsibility of this addon? As the user can configure themselves whether to show the sidebar and toolbar, essentially this addon does not have control over their visibility. We can however, control that visibility in the embeddable package.

yeah ok fair enough