feat: implement FormHelperText base component wrapper (#1400) - #1659
feat: implement FormHelperText base component wrapper (#1400)#1659abhinavkdeval08-design wants to merge 10 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new wrapper component, FormHelperText, which wraps Material-UI's FormHelperText component, and updates peer dependency flags in package-lock.json. The review feedback recommends wrapping the new component with React.forwardRef to ensure proper integration with other components and form libraries by forwarding the ref to the underlying DOM element.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
KhushamBansal
left a comment
KhushamBansal
left a comment
There was a problem hiding this comment.
@abhinavkdeval08-design Please sign your commits and address the bot's feedback on your PR.
Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
0f694d4 to
536f203
Compare
|
Hi @KhushamBansal, thank you for the review! I have addressed the bot's feedback by wrapping the component in React.forwardRef and adding the displayName. I've also amended the commit to include the DCO sign-off. Please let me know if it looks good to go! |
|
@leecalcote @KhushamBansal |
|
@abhinavkdeval08-design Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
Hi @Bhumikagarggg, thank you for the invite! Unfortunately, I won't be able to join the website call tomorrow due to prior personal commitments. However, I have already addressed the code feedback by implementation of |
|
@KhushamBansal @Bhumikagarggg @leecalcote |
|
@leecalcote @KhushamBansal @rishiraj38 @Bhumikagarggg |
|
@abhinavkdeval08-design Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Bhumikagarggg
left a comment
Bhumikagarggg
left a comment
There was a problem hiding this comment.
- Please change the name of file from
src/base/FormHelperText/FormHelperText.tsxthis tosrc/base/FormHelperText/FormHelperTextIcon.tsx - Please take this PR as reference - #1332
Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
|
@Bhumikagarggg @leecalcote @KhushamBansal I've renamed the component file to |
6f78a41 to
e344196
Compare
KhushamBansal
left a comment
KhushamBansal
left a comment
There was a problem hiding this comment.
@abhinavkdeval08-design The file shouldn't be named src/base/FormHelperText/FormHelperTextIcon.tsx. It should be src/base/FormHelperText/FormHelperText.tsx. The component isn't an icon.
Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
5f0765b to
483690c
Compare
|
@KhushamBansal That makes total sense, it is indeed a text wrapper and not an icon. I had renamed it earlier based on the previous review request, but I have now reverted the file name back to |
|
@leecalcote @KhushamBansal @Bhumikagarggg kindly review the PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughA typed ChangesFormHelperText component
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change adds and exports a FormHelperText component backed by MUI without changing authentication, data handling, runtime configuration, or deployment behavior. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The pull request implements the missing FormHelperText component, adds MUI-based typings, forwards refs and props, and exposes the component through local and root-level exports. These changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/base/FormHelperText/FormHelperText.tsx`:
- Around line 6-8: Replace the empty SistentFormHelperTextProps interface with a
type alias that preserves its extension of MuiFormHelperTextProps, removing the
unused empty-interface declaration and its comment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 600cd717-a3bc-410b-830f-ddb11bd6d530
📒 Files selected for processing (3)
src/base/FormHelperText/FormHelperText.tsxsrc/base/FormHelperText/index.tssrc/base/index.tsx
|
@abhinavkdeval08-design, not @leecalcote, but @KhushamBansal and @Bhumikagarggg |
KhushamBansal
left a comment
KhushamBansal
left a comment
There was a problem hiding this comment.
@abhinavkdeval08-design Could you attach demo video of this component in the PR description?
Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
|
@KhushamBansal, since FormHelperText is a pure structural base wrapper around Material-UI’s core component with forwarded ref and type definitions (rather than an interactive or visual feature widget like a table/modal), it is primarily designed to be consumed downstream within form controls (e.g., FormControl, TextField). The component has been verified with local tsup production builds and strict TypeScript lint checks (all CI checks are passing green). I've resolved the empty interface ESLint warning as well. Let me know if there are any other specific code-level checks needed, or if it looks good to merge! |
PARTH-TUSSLE
left a comment
PARTH-TUSSLE
left a comment
There was a problem hiding this comment.
Hey @abhinavkdeval08-design , I went through the current implementation. The earlier concerns around ref forwarding, the filename, package-lock changes, and the empty interface have all been addressed, and the current diff looks clean and appropriately scoped.
Before I approve, I'd just like to see a small unit test covering the wrapper, especially ref forwarding and basic prop/child rendering so we have regression coverage for this base component. Also, please attach the demo video requested earlier in the PR description.
…rding Signed-off-by: Abhinav Deval <abhinavkdeval08@gmail.com>
Screen.Recording.2026-08-30.184453.mp4Hi @PARTH-TUSSLE @KhushamBansal, I have added the unit test suite in
I have also attached the demo video verifying these test states in the PR description above. All local builds and lint checks are green. Awaiting your approval to merge! |
5 participants
Description
This PR resolves #1400 by implementing the missing
FormHelperTextcomponent wrapper from@mui/materialinto the Sistent design system base components directory matrix.Changes Proposed
FormHelperTextdirectory component undersrc/base.SistentFormHelperTextPropsextending MUI's core typings to preserve strict type definitions.cross-envandtsup.cc @leecalcote @KhushamBansal
Please review this PR and let me know if any changes are required. Happy to iterate!
Summary by CodeRabbit