-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo has been changed #5023
Logo has been changed #5023
Conversation
Signed-off-by: VivekBaldha0712 <[email protected]>
🚀 Preview for commit e3f15b9 at: https://6526115579509c77faacbb98--layer5.netlify.app |
@VivekBaldha0712 The changes look good but do you think we can increase the size a bit? The previous logo looks bigger than the current one. What are your thoughts on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, It looks good although.
@Mohith234 , Yes the previous logo is bigger but this one also looks good. It will not impact a lot |
@VivekBaldha0712 it's a good practice when making pr to write a descriptive message that should tell where this change has been made, so we can review and merge pr's soon |
So where is this changes on which page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, but could you also mention where these changes were made? Alternatively, you could try adding screenshots of the changes.
@sudhanshutech @Gautam-04 I apologize, here is the url https://layer5.io/cloud-native-management/meshery/getting-started |
Description
This PR fixes #5015
Notes for Reviewers
Signed commits