Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrelated Inter Page Navigation Removed #5017

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Unrelated Inter Page Navigation Removed #5017

merged 1 commit into from
Oct 19, 2023

Conversation

dhamkirti21
Copy link
Contributor

@dhamkirti21 dhamkirti21 commented Oct 9, 2023 •
edited
Loading

Description
Added Meaningful Navigation

This PR fixes ##4968

Notes for Reviewers
@Mohith234 @ritiksaxena124
Please review this PR Now

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 9, 2023

🚀 Preview for commit 4c6fc55 at: https://6523bffe83e18d5baafacd6a--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes

@dhamkirti21 dhamkirti21 mentioned this pull request Oct 10, 2023
Closed
1 task
@sudhanshutech
Copy link
Member

changes looks good @dhamkirti21 , will you please make transition to inter page navigation smooth, like when we click on any reference and it move to that certain section of page so it should move smoothly not abruptly

@vishalvivekm
Copy link
Contributor

changes looks good @dhamkirti21 , will you please make transition to inter page navigation smooth, like when we click on any reference and it move to that certain section of page so it should move smoothly not abruptly

@dhamkirti21

@leecalcote
Copy link
Member

changes looks good @dhamkirti21 , will you please make transition to inter page navigation smooth, like when we click on any reference and it move to that certain section of page so it should move smoothly not abruptly

This is a good ask, @sudhanshutech. Will you please open a new issue describing this enhancement request?

leecalcote
leecalcote approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good work here, @dhamkirti21 👏

@leecalcote leecalcote merged commit a45fb54 into layer5io:master Oct 19, 2023
4 checks passed
@leecalcote
Copy link
Member

Yay! 🎈

@Mohith234 Mohith234 mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
area/handbook
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dhamkirti21 @l5io @saurabh100ni @sudhanshutech @vishalvivekm @leecalcote