-
Notifications
You must be signed in to change notification settings - Fork 127
Add Design Hyperlink for embedding Meshery designs #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Design Hyperlink for embedding Meshery designs #713
Conversation
Signed-off-by: Wyllie Fang <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Screencast.from.2025-07-24.17-26-12.webm@Vincamine is it possible, not to allow user to manipulate meshery designs like zoom and pan. |
If they wanted just a static image, then they don’t need to embed a design. Making the design non-interactive is the opposite of what we’re trying to do. @ShashaankS @vr-varad @Namanv0509 |
@Vincamine as all designs url have the format ref
|
Thats a great idea @vr-varad |
yes that's a good one to get on . will surely get things better to manage .
|
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
right!! That's a great suggestion! I'm changing it. Thank you Varad!! |
emm.. it's a good idea. But if we need to simplify the ID format, we should modify it in layer5labs/... instead of here. |
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
|
||
<!-- Auto-generate link if not provided --> | ||
{{ $autoLink := "" }} | ||
{{ if not $Link }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo , $Link -> $link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gosh.. thank you Naman!!
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
@@ -65,10 +140,17 @@ | |||
- Width: 100% (responsive to container width) | |||
- Border: 1px solid #eee (light border for visibility) | |||
--> | |||
|
|||
{{ if $link }} | |||
<a href="{{ $link }}" target="_blank" rel="noopener" style="text-decoration: none; color: inherit;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here should be $finallink @Vincamine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And logic seems to be off as well,
up there if there will be no link, we are using autolink, but down here if the link is not there we are not applying the link.
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
Signed-off-by: Wyllie Fang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vincamine Excellent work on this PR! This is a much-needed feature, and I appreciate you implementing the community's feedback.👍 I have a few suggestions to further improve it.
1. (High Priority) Adjust Frame Height to Improve Page Scrolling
There is a usability issue with the current height of the embedded design container. On pages with full
-width designs, the frame is so large that it occupies most of the screen.
When a user scrolls down the page, their mouse pointer inevitably enters the design area. At this point, the scroll wheel action is "hijacked" by the design to control its zoom level, which stops the page from scrolling. This traps the user, forcing them to carefully move their mouse to the narrow margins of the page to continue reading. This can be a very frustrating experience.

Suggestion: Could you please reduce the width of the container? For example, you'll notice that the "design" container is wider than the text above and below it.
2. Minor Suggestions
Here are a couple of smaller points for consideration:
-
Button Text: Since the designs are created and managed in Meshery's "Kanvas" designer, would it be more accurate to change the button text from
🔗 Open in Meshery
to🔗 Open in Kanvas
? -
Sizing of
half
-width Designs: For our use cases for our embedded designs, we typically use them in two ways: for displaying a small, focused part of a design, or for showing a large, complete diagram. So we havefull
andhalf
sizes for designs. For now, I think thehalf
size is adequate, but I wanted to bring it to your attention in case you had other thoughts.
The following two places are used in addition to the embedded design document:
3. Post-Merge Task: Update Documentation
Once this PR is merged, please remember to update the relevant documentation. It would be very helpful to clarify the behavior and limitations of embedded designs for our users and content creators.
Specifically, the documentation should answer questions like:
- Is the embedded view read-only? If a user pans or zooms the design, does it affect the original source file?.
- What happens to the embedded view if the original design is deleted or change the visibility to private, or the design is then published? Does the link break? Does the embed show an error?
This will help set the correct expectations for anyone using this feature. You can create a separate issue for this later.
Great job again, and let me know what you think of these suggestions!
Notes for Reviewers
Related issues with
https://github.com/layer5labs/meshery-extensions-packages/issues/297 and https://github.com/layer5io/academy-theme/issues/12
Use simple glass effect
Screen.Recording.2025-07-23.at.7.22.34.PM.mov
Signed commits