Skip to content

image width fix #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

image width fix #712

merged 2 commits into from
Jul 25, 2025

Conversation

Namanv0509
Copy link
Member

Notes for Reviewers

This PR is to maintain uniformity in theme with docs from this PR
This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Namanv0509 <[email protected]>
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 15e0691
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/68833edb225b4500088a1c1b
😎 Deploy Preview https://deploy-preview-712--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@leecalcote
Copy link
Member

leecalcote commented Jul 24, 2025

@Namanv0509, please request @zihanKuang's review.

@zihanKuang
Copy link
Contributor

Hi @Namanv0509, could you provide some examples and comparisons? For instance, which original page had this issue, and how has it been fixed after your modifications?
Thanks.

@Namanv0509
Copy link
Member Author

The changes made at layer5io/academy-theme#49 (comment) , are done here as well to maintain the uniformity . @zihanKuang

Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zihanKuang zihanKuang merged commit 16d66cd into layer5io:master Jul 25, 2025
6 checks passed
@zihanKuang
Copy link
Contributor

Hi @Namanv0509,

I was reviewing the page at https://docs.layer5.io/cloud/self-hosted/white-labeling/ today and found the cause of the image display issue.

I've checked the code, and it seems to be caused by a change from width: 100% to width: auto;. I actually think the change to width: auto; is a positive one. Perhaps we can add a more specific rule to override the global one?

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants