-
Notifications
You must be signed in to change notification settings - Fork 127
update docs for static counts
#710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs for static counts
#710
Conversation
Signed-off-by: saurabhraghuvanshii <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Not sure if we have to mention these , as why would orgs do this if its not even in academy-example ( and they are going to use the template and the guide only ig ) |
What logic is used in the automatic calculation? |
Like we did it in our Prs, by mistake. Updated this because of some discussion on Slack. |
Honestly I don't know what is logic behind it, but you mentioned it will by Cloud Server. |
|
@leecalcote thanks for information, I will update accordingly. And read docs carefully for best practices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saurabhraghuvanshii ,
Thanks for taking the initiative to maintain and update the docs. However, since we don't want users to use this, and it's currently not used in the front matter of our example repo, we don't need to add a warning. Users likely won't know what this is anyway, and it could easily lead to misunderstandings.
I'll close this PR then.👍
Notes for Reviewers

This PR fixes #
Signed commits