Skip to content

update docs for static counts #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

saurabhraghuvanshii
Copy link
Contributor

Notes for Reviewers
Screenshot 2025-07-24 011810

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: saurabhraghuvanshii <[email protected]>
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit bb9efbc
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/68833d2d08cd3b0008e92639
😎 Deploy Preview https://deploy-preview-710--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Namanv0509
Copy link
Member

Not sure if we have to mention these , as why would orgs do this if its not even in academy-example ( and they are going to use the template and the guide only ig )

@leecalcote
Copy link
Member

What logic is used in the automatic calculation?

@saurabhraghuvanshii
Copy link
Contributor Author

Not sure if we have to mention these , as why would orgs do this if its not even in academy-example ( and they are going to use the template and the guide only ig )

Like we did it in our Prs, by mistake. Updated this because of some discussion on Slack.

@saurabhraghuvanshii
Copy link
Contributor Author

What logic is used in the automatic calculation?

Honestly I don't know what is logic behind it, but you mentioned it will by Cloud Server.

@leecalcote
Copy link
Member

leecalcote commented Jul 23, 2025

@saurabhraghuvanshii

  1. I appreciate you taking initiative to make this warning note in docs. This sort of thing is great. 💯
  2. We can skip inclusion of this particular note given that all content should be void of these front matter variables. We need to ensure that each of these three front matter variables are removed from all content. Please help in confirming this. You're right that these three statistics will be dynamically calculated by the Cloud server. I asked about the logic in the calculation, thinking that you were including weight in this warning note.
  3. Instead we can include mention of how to use the weight variable and what best practice we promote in its use or lack thereof. In terms of the logic behind this variable, Hugo docs will confirm.

@saurabhraghuvanshii
Copy link
Contributor Author

@leecalcote thanks for information, I will update accordingly. And read docs carefully for best practices

Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saurabhraghuvanshii ,

Thanks for taking the initiative to maintain and update the docs. However, since we don't want users to use this, and it's currently not used in the front matter of our example repo, we don't need to add a warning. Users likely won't know what this is anyway, and it could easily lead to misunderstandings.

I'll close this PR then.👍

@zihanKuang zihanKuang closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants