Repository navigation
chore: bump minor rather than major for pre-1.0 breaking changes - #73
Merged
Merged
Conversation
Matches the sibling provider repos' release-please configuration. Without this flag, release-please's default versioning escalates any breaking change to a major bump even below 1.0.0 — the fix! in #64 retitled the open release PR (#72) to 1.0.0 instead of 0.9.0. The 1.0 milestone should be a deliberate decision, not a side effect of a config gap.
joker23
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bump-minor-pre-major: trueto the release-please config, matching the Ruby provider repo's configuration.Why: release-please's default versioning strategy escalates a breaking change to a major bump even below 1.0.0. The
fix!:in #64 therefore retitled the open release PR #72 to 1.0.0 instead of 0.9.0. Crossing to 1.0 should be a deliberate GA decision, not a side effect of a missing config flag.Effect: merging this PR triggers a release-please run, which will recompute #72 to 0.9.0 (a
Release-As: 0.9.0override has also been added to #64's body as a belt-and-suspenders measure — both mechanisms agree). The changelog is unchanged and the release remains flagged as breaking.With this flag, pre-1.0 breaking changes bump the minor (0.x → 0.(x+1)) going forward.
Note
Overview
Adds
bump-minor-pre-major: true torelease-please-config.jsonso release-please treats breaking changes as minor bumps while the package is still below 1.0.0, instead of jumping to 1.0.0 by default.This aligns versioning with the Ruby provider repo and keeps a deliberate 1.0.0 GA cut separate from conventional-commit breaking changes (e.g. retitling an in-flight release PR from 1.0.0 to 0.9.0 without changing the breaking changelog content).
Reviewed by Cursor Bugbot for commit ae994ba. Bugbot is set up for automated code reviews on this repo. Configure here.