-
Notifications
You must be signed in to change notification settings - Fork 4
Add GitHub Actions workflow to publish to MCP registry #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Follows MCP registry publishing guidelines - Triggers on releases and manual dispatch - Uses existing NPM_TOKEN secret - Publishes to npm first, then MCP registry - Uses GitHub OIDC authentication for MCP registry Co-Authored-By: Kane Parkinson <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- name: Publish to npm | ||
run: npm publish | ||
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already publish to npm through Speakeasy's workflows: https://github.com/launchdarkly/mcp-server/blob/main/.github/workflows/sdk_publish.yaml#L22
Why are we duplicating this step? Can we unify the current publication process and publishing to the registry?
Good point! You're absolutely right that we shouldn't duplicate the npm publishing step. The existing Speakeasy workflow already handles npm publishing. I'll update this workflow to focus only on the MCP registry publishing part. The workflow should either:
I'll remove the npm publish step and keep only the MCP registry-specific steps. This way we avoid duplication while still enabling MCP registry publishing. |
- Remove Node.js setup, npm ci, build, and publish steps - Keep only MCP registry-specific publishing steps - Addresses reviewer feedback about Speakeasy workflow already handling npm publishing Co-Authored-By: Kane Parkinson <[email protected]>
Thanks for the feedback! You're absolutely right. I've updated the workflow to remove the npm publishing duplication. The updated workflow now:
This way the existing Speakeasy workflow continues to handle npm publishing when .speakeasy/gen.lock changes, and this workflow handles only the MCP registry submission when releases are created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Related issues
This PR addresses the request to publish the LaunchDarkly MCP server to the Model Context Protocol registry following the guidelines at https://github.com/modelcontextprotocol/registry/blob/main/docs/guides/publishing/github-actions.md.
Describe the solution you've provided
This PR adds a new GitHub Actions workflow (
.github/workflows/publish-mcp-registry.yml
) that publishes the MCP server to the MCP registry. The workflow:workflow_dispatch
The workflow coordinates with the existing Speakeasy publishing process by handling only MCP registry submission while leaving npm publishing to the existing
sdk_publish.yaml
workflow.Describe alternatives you've considered
Alternative trigger strategies:
Alternative authentication methods:
Integration approaches:
Additional context
Important review points:
github.com/modelcontextprotocol/registry/releases/download/v1.0.0/
- verify this URL and version are stableWorkflow coordination:
sdk_publish.yaml
(Speakeasy) handles npm publishing when.speakeasy/gen.lock
changesTesting strategy:
workflow_dispatch
triggerLink to Devin run: https://app.devin.ai/sessions/0e8e01387d7e447ea3d82a638f30cc8f
Requested by: @kparkinson-ld (Kane Parkinson)