feat(components): Typography token styles added to Heading, Text, Label, Code components #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3aa8f53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Size Change: +2.42 kB (+0.46%) Total Size: 530 kB
ℹ️ View Unchanged
|
added 3 commits
July 24, 2025 22:58
Zuzze
commented
Jul 24, 2025
apucacao
reviewed
Jul 25, 2025
apucacao
approved these changes
Jul 25, 2025
Zuzze
changed the title
matthewferry
requested changes
Jul 25, 2025
There was a problem hiding this comment.
This is dope! And thank you for proactively getting this done! Just a couple things:
- let's remove labels from being used in the api for
<Text/>. we have<Label />for that and don't want to encourage those styles in regular copy - I find the use of single variant prop a bit awkward. I can be peaceful with us doing it for this pass (I know there are feels about expanding props), but I would prefer the API be explicit for
sizeandweight.
added 4 commits
July 28, 2025 23:57
added 5 commits
July 30, 2025 12:24
Just curious: would it make sense to use "emphasized" or something similar to make clear the prop semantics vs visual effect? |
Zuzze
changed the title
Could be, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To streamline text usage on instance level,
Text,LabelandHeadingsupport now the following optional props (No breaking changes):variant: if not given, uses old default style as beforemaxLines: default off like beforeNew shorthand syntax looks like
<Text>Lorem ipsum dolor sit est</Text>-> defaults to<Text size="medium" bold={false}><Heading>Welcome</Heading>-> defaults to<Heading size="medium" bold={true}><Label>Name</Label>-> defaults to<Label size="medium"><Code>const var = 1</Code>-> defaults to\<Code size="medium">New props for
Heading,Text,Code,Label:bold: If text is emphasized, will be true. Design team will align so that Figma variants will only have 2 font weights for each. Label has only one font weight in the props API but if inside form where orientation="horizontal" lighter weight will be applied.size:small,medium,largewill be used. Label and Code have only 2 sizes. More sizes may be added in futureUnder the hood the component also handles:
codefor code,smallfor small text andpfor bigger text and levels for headingsUnderlying HTML token can still be changed by react-aria props'
elementTypein Text andlevelin Heading like before.Screenshots (if appropriate):
Text
Heading
Label
Code
Housekeeping
TextandHeading,Code,LabelfromTypographytokensunionin prop tableDark mode
All text components were also tetsted in dark mode.
Testing approaches
New stories will be detected in future by Chromatic