Add fixer-level "ignore" option, fix file filtering in custom fixers #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aengelberg
force-pushed
the
ae/RO-2261/fixer-level-ignore
branch
from
e4b77a6 to
a06e9dd
Compare
zmdavis
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ignore": ["someFile"]in your.felixrc.jsonthat's nested under a specific fixer. This ignores those files only when that fixer runs."extensions","paths", and"ignore"options, before passing those filtered files to the custom command.Testing
I was kinda hoping to write unit tests for this new code but ran into challenges mocking the config manager. I'm going to punt on adding tests but I was able to confirm this works using a test Gonfalon PR.