mysql: add TLS server name override for SNI#4130
Open
mingley wants to merge 2 commits intolaunchbadge:mainfrom
Open
mysql: add TLS server name override for SNI#4130mingley wants to merge 2 commits intolaunchbadge:mainfrom
mingley wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
Signed-off-by: Michael Ingley <mingley@linkedin.com>
4a575f4 to
4f94625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tls_server_nameoverride toMySqlConnectOptionsProblem
VerifyIdentityties both TLS SNI and certificate hostname verification to the TCPhostvalue. Inreal deployments (e.g., HAProxy or multi-instance pools), clients often connect via an IP or
internal alias that does not match the server certificate’s DNS name. This causes TLS verification
failures even when the CA and certificate are correct.
Rationale
This change lets users explicitly specify the TLS server name used for SNI + hostname verification
while keeping the TCP host unchanged. It is additive and opt-in: existing behavior is unchanged
unless the new option is set.
Testing
VerifyIdentityenabled; connection + simple query succeeded using the SNI override