Add pg connection options creation without environment #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
add/no-defaults-pg-options
branch
from
b0b07d3 to
f8ad9a0
Compare
dkubb
reviewed
Apr 20, 2025
mbj
force-pushed
the
add/no-defaults-pg-options
branch
from
f8ad9a0 to
1c2b3a3
Compare
mbj
force-pushed
the
add/no-defaults-pg-options
branch
from
1c2b3a3 to
a836e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a breaking change?
no.
Rationale:
I make SQL tools that need to behave correctly in situations the environment cannot be relied upon (developer boxes, my code is run as a 3rd party library etc) and where my SQL connections need to be precisely controlled by my own code.
Before my only option was to use
new_without_pgpassand explicitly unset any field that may have been picked up by that function in my own code. But this is breaky assqlx-postgresqlmay accumulate new fields in new releases. Also not all fields have APIs to unset the effect of env reflection.