Fix race condition adding background run after adding the job to Bullmq #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoxelox
reviewed
Oct 15, 2025
andresgutgon
force-pushed
the
fix/check-complete-event-on-background-run
branch
from
3dc9378 to
04132cb
Compare
run is set in Redis
andresgutgon
force-pushed
the
fix/check-complete-event-on-background-run
branch
from
72c3da9 to
5eb7ca7
Compare
andresgutgon
commented
Oct 16, 2025
| const repository = new RunsRepository(workspace.id, project.id) | ||
| const creating = await repository.create({ runUuid, queuedAt: new Date() }) | ||
| if (creating.error) return Result.error(creating.error) | ||
| const run = creating.value |
There was a problem hiding this comment.
This was the issue. By the time we add this to the active runs the bull mq was already run and start failed
andresgutgon
changed the title
geclos
reviewed
Oct 17, 2025
packages/core/src/cache/index.ts
Outdated
| export const withCacheLock = async <T>({ | ||
| lockKey, | ||
| callbackFn, | ||
| timeout = 5000, |
There was a problem hiding this comment.
could we reduce this timeout? 5 seconds is huge for redis, should be one at most 1 second and that's already stretching it
geclos
previously approved these changes
Oct 17, 2025
neoxelox
reviewed
Oct 17, 2025
neoxelox
previously approved these changes
Oct 17, 2025
Co-authored-by: Alex Rodríguez <[email protected]>
andresgutgon
commented
Oct 17, 2025
packages/core/src/cache/index.ts
Outdated
| export const withCacheLock = async <T>({ | ||
| lockKey, | ||
| callbackFn, | ||
| timeout = 5000, |
There was a problem hiding this comment.
Suggested change
| timeout = 5000, | |
| timeout = 1000, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A background run job finished, but the UI didn't noticed and tried to attach to it.
What was the problem?
I conducted a stress test by running multiple background tasks simultaneously. Doing that, I saw that in the enqueue phase, we enqueue first in BullMQ, and later we add it to active runs.
Also I added backoff retry on the lock mechanism so we have more contention in case of many concurrent writes. But the main fix is the race condition enqueuing first and not adding first to active runs