Custom settings #98
Merged
Custom settings #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bug fixed related with AdvertisedDeviceCallbacks and templates. #define BLEMIDI_CREATE_INTANCE fixed
removed logging
added : _midiChar.writeValue((uint8_t)0); otherwise the device will disconnect immediately
cleanup - removed all polling code
fixed template sintaxis of Client
Serial.print changed by debugging verbose. It may be abled using #define MIDIBLECLIENTVERBOSE
Improved IF-syntaxis
Mayor changes in all configuration setup. Create a custom Config Struct for the client, it heritages from regular repo Struct and adds specific settings of the class. All configurations, including onPassRequest function, may be configured in the upper layers of the code, like in main.c
Tabulation indentation fixed after last commit changes and other minor changes in comments
Added after Nimble Lib update. end() updated.
Write directly to .yaml file
Added all configurations options
When using a template instance in two different ways (for example, different settings struct for differents objects), a lot of lines of warning appear due to some variables being unused. Using these lines, those variables are used for doing nothing and the warnings go away.
BleClient Custom settings
fix bug when end() called (@aselectroworks) callback with deviceName (@MicroMidi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.