Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop SoftHSM from the matrix for now #518

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Feb 10, 2025

We build on Mac OS X just to ensure the code builds, however we do not absolutely need to run multiple tests, as functionality with the various tokens is already tested in the rest of the CI

Given lately MAc OS X 14 + SoftHSM always times out, disable it from the matrix for now.

Note that the rest of the conditionals are intentionally preserved, so that we can simply re-add sofhtsm to the matrix should we want to.

Resloves #515

Description

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

We build on Mac OS X just to ensure the code builds, however we do not
absolutely need to run multiple tests, as functionality with the various
tokens is already tested in the rest of the CI

Given lately MAc OS X 14 + SoftHSM always times out, disable it from the
matrix for now.

Note that the rest of the conditionals are intentionally preserved, so
that we can simply re-add sofhtsm to the matrix should we want to.

Signed-off-by: Simo Sorce <[email protected]>
@simo5 simo5 requested review from neverpanic and Jakuje February 10, 2025 15:33
@simo5 simo5 added the covscan-ok Coverity scan passed label Feb 10, 2025
@simo5 simo5 merged commit c0c4ed6 into latchset:main Feb 10, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
covscan-ok Coverity scan passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants