Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid requesting a PIN just to load a cert #517

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

simo5
Copy link
Member

@simo5 simo5 commented Feb 7, 2025

Description

In many tokens certificates can be loaded without logging into the token,
If the URI unequivocally refrences a certificate object, try to load it without forsing a login.

Fixes #508

Checklist

  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

In many tokens certificates can be loaded without logging into the
token,
If the URI unequivocally refrences a certificate object, try to load
it without forsing a login.

Signed-off-by: Simo Sorce <[email protected]>
@simo5
Copy link
Member Author

simo5 commented Feb 7, 2025

@embetrix any chance you can test if this code change allows your code to work w/o having to set what the store expects?

@simo5 simo5 requested a review from Jakuje February 7, 2025 21:50
tests/ccerts.c Outdated Show resolved Hide resolved
tests/ccerts.c Outdated Show resolved Hide resolved
tests/ccerts.c Outdated Show resolved Hide resolved
@simo5 simo5 force-pushed the cert_no_pin branch 2 times, most recently from bee15f7 to a6cc184 Compare February 10, 2025 13:59
@simo5 simo5 added the covscan Triggers Coverity Scanner label Feb 10, 2025
@github-actions github-actions bot removed the covscan Triggers Coverity Scanner label Feb 10, 2025
This allows to proprely test that certs load correctly even when no PIN
is provided.

Signed-off-by: Simo Sorce <[email protected]>
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Macos is slow so it timed out in the uri test. Tracked in separate issue.

@simo5 simo5 merged commit 8cb0f0e into latchset:main Feb 10, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

certificate load require PIN
2 participants