-
-
Notifications
You must be signed in to change notification settings - Fork 660
Upgrade to intervantion v3 #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to intervantion v3 #1189
Conversation
@driesvints The functionality works but I am not able fix the test that I wrote. The test runs fine on my local (MacOS + Herd) but fails on github actions. I suspect it's because of different environments or something similar but not sure. Should I remove the test for now so you can merge this PR? |
@tauseefsshah heya sorry for the long wait here.. could you maybe rebase this PR and fix the conflicts before I review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks real good overall!
Hey @driesvints 👋 Made the following updates:
Please review now and also what about the test I wrote? It's still failing on github actions. Should I skip/remove the test for now? |
I disabled that test for now. Couldn't figure it out either but it's running locally and I verified this approach works. Thanks a bunch for your work here @tauseefsshah! Sorry it took me so long to review this. |
I now see the text is just a little too high. Could you adjust that maybe @tauseefsshah ? ![]() Should be more like this: ![]() |
Hey @driesvints |
Hey @driesvints Have raised a PR #1262 to fix the positioning |
This PR aims to fix #1187 using laravel's
response()
method and upgrade intervention tov3
.