Fix Translation not found when contains non-standard character #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joetannenbaum
left a comment
joetannenbaum
left a comment
There was a problem hiding this comment.
Good call, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
This PR depends on laravel/vs-code-php-parser-cli#21
Currently, the
translations.phptemplate usesjson_encodewithout any flags. As a result, during serialization to JSON, all symbols and slashes are escaped. For example:Products → Settings=>Products \u2192 SettingsAPI / ERP=>API \/ ERPthen linkProvider cannot find such elements in the translation repository, because VsCode returns raw, unescaped keys.
This PR adds 2 additional flags to json_encode: JSON_UNESCAPED_UNICODE and JSON_UNESCAPED_SLASHES. I'm not 100% sure but I think, both javascript object and php array can use symbols and slashes in the property/key names, so there should be no conflict.