Support for parser for blade component attributes #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From laravel/vs-code-php-parser-cli#13:
This PR adds support for parser for blade component attributes. Every attribute with a function supported by the extension has a link to the target file.
Before:
After:
Works with and without blade prefix/suffix statements.
Most of the logic is in the laravel/vs-code-php-parser-cli#13 but for proper display of values in hover, we need to change the calculation of
linkRangeto exclude double quote from the attribute:linkRange should return range of:
'example.label'not:
"{{ trans('example.label') }}"This PR adds an additional
negative lookbehindfor the regex to fix this issue.Fixes #370