fix: Avoid Filtering Failed Jobs Timestamp in Memory #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To display queue metrics, Vapor loads all `failed_jobs` and filters the period (1m, 5m, 10m, 30m, 1h, 24h, 7d, 30d) in memory. When the failed_jobs table has a large number of rows, usually as a result of not pruning failed_jobs on a regular-basis, it would cause Queue Metrics to fail with HTTP status 502. `getTable` was made public via laravel/framework#56384 Note: In another PR, we could also filter all the other filter options (id, queue, query)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To display queue metrics, Vapor loads all
failed_jobsand filters the period (1m, 5m, 10m, 30m, 1h, 24h, 7d, 30d) in memory. When thefailed_jobstable has a large number of rows, usually as a result of not pruningfailed_jobson a regular basis, it would cause Queue Metrics to fail with HTTP status 502.getTablewas made public via laravel/framework#56384As a workaround, we could run the following as a command:
php artisan queue:prune-failed --hours=720Or we could also add this as a scheduled job:
This will delete every failed job that is older than 30 days.
Note: In another PR, we could also filter all the other filter options (id, queue, query)