Skip to content

Change to hyphenate prefixes and cookie names #56172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Change to hyphenate prefixes and cookie names #56172

merged 2 commits into from
Jul 2, 2025
+3 −3

Conversation

u01jmg3
Copy link
Contributor

@u01jmg3 u01jmg3 commented Jun 29, 2025

Same as laravel/laravel#6636

(Targeting master as it's considered a breaking change)

@taylorotwell
Copy link
Member

No need for the cookie name change.

@taylorotwell taylorotwell marked this pull request as draft July 1, 2025 16:02
@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Jul 1, 2025 •
edited
Loading

  • Is it okay to diverge from laravel/laravel (as the PR there did alter the cookie name)?
  • Presumably, this is to prevent a breaking change that you feel isn't necessary?

@u01jmg3 u01jmg3 marked this pull request as ready for review July 1, 2025 19:39
@taylorotwell taylorotwell merged commit 693bef8 into laravel:master Jul 2, 2025
19 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u01jmg3 @taylorotwell