Loderunner cylex test eval#96
Open
soumide1102 wants to merge 4 commits into
Open
Conversation
hickmank
previously approved these changes
Feb 26, 2026
Collaborator
hickmank
left a comment
hickmank
left a comment
There was a problem hiding this comment.
Upon brief review this looks great. Will this work with the PR for loderunner PLI evaluation?
Contributor
Author
|
@hickmank yes, it will. I want to point out that I have written separate training/eval datastep functions for cylex and pli, that can be called by the same training/eval epoch functions. The epoch functions default to pli, so nothing in the harnesses or other scripts that train/evaluate loderunner with pli change due to this PR. |
Collaborator
|
@soumide1102 do you need/want help debugging why the tests are failing? It doesn't look obvious to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the cylex version for the test eval code being added in #95.
It depends on changes being added through #95 and the cylex PR #69.