Add dataset class to train LodeRunner on one of the MPP datasets#72
Conversation
hickmank
left a comment
There was a problem hiding this comment.
Nice. A few comments, marking "request changes" since it's a draft. I guess the next check would be to see if LodeRunner can actually be evaluated on an output of this dataset class.
There was a problem hiding this comment.
If this is copied from the MPP repo we should not include it in Yoke. If we need the functionality we could add their module as an optional dependency in the pyproject.toml.
There was a problem hiding this comment.
This looks like a great start. We'll have to think about how the in_vars and out_vars inputs to LodeRunner should be handled when training off of this data. But this looks close to something usable!
|
@schakrabarti-lanl Awesome Sharmistha, thanks for working on this. It doesn't look too far away from being able to do a test training run of the LodeRunner architecture on this dataset! |
This is a dataclass that will be used to train LodeRunner on one of the PDEBench datasets.