Skip to content

Add dataset class to train LodeRunner on one of the MPP datasets#72

Draft
schakrabarti-lanl wants to merge 4 commits into
lanl:mainfrom
schakrabarti-lanl:issue-70-dataset-class-training-loderunner-on-pdebench
Draft

Add dataset class to train LodeRunner on one of the MPP datasets#72
schakrabarti-lanl wants to merge 4 commits into
lanl:mainfrom
schakrabarti-lanl:issue-70-dataset-class-training-loderunner-on-pdebench

Conversation

@schakrabarti-lanl
Copy link
Copy Markdown
Contributor

This is a dataclass that will be used to train LodeRunner on one of the PDEBench datasets.

Copy link
Copy Markdown
Collaborator

@hickmank hickmank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few comments, marking "request changes" since it's a draft. I guess the next check would be to see if LodeRunner can actually be evaluated on an output of this dataset class.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is copied from the MPP repo we should not include it in Yoke. If we need the functionality we could add their module as an optional dependency in the pyproject.toml.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start. We'll have to think about how the in_vars and out_vars inputs to LodeRunner should be handled when training off of this data. But this looks close to something usable!

@hickmank
Copy link
Copy Markdown
Collaborator

@schakrabarti-lanl Awesome Sharmistha, thanks for working on this. It doesn't look too far away from being able to do a test training run of the LodeRunner architecture on this dataset!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants