[WIP] START_study.py upgrade#34
Draft
hickmank wants to merge 7 commits into
Draft
Conversation
galegozi
suggested changes
Apr 7, 2025
Contributor
galegozi
left a comment
galegozi
left a comment
There was a problem hiding this comment.
Hi @hickmank ,
I have a couple of questions.
First of all, have you tested this with both the JSON config and the SLURM template to make sure it works? If not, would you be able to move the change to the channel subsampling harness (where I am using the config to generate SLURM files)?
Second of all, this change would break all existing studies. I understand you do not want two versions of running studies; however, I am strongly against breaking existing code...
Contributor
|
@hickmank Any updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
START_study.pyscript a command-line executable calledyoke-start-study.The new behavior is currently implemented in the
burr_lsc_density_surrogateharness.With this behavior a
HarnessStudyclass is defined that is then utilized by thestart_studyscript.Harnesses now only have "template" input and slurm files and no longer require the symlink to a
START_study.pyscript.NOTE: This is a repo-wide change so the harnesses will have to be modified prior to a merge. That means I'll have to pair down the number of harnesses first.