Skip to content

Commit

Permalink
Fixup later - fix rank issue in SoilHydrologyMod
Browse files Browse the repository at this point in the history
  • Loading branch information
@rfiorella
rfiorella committed May 15, 2024
1 parent 0eb24ef commit 7db2797
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/elm/src/biogeophys/SoilHydrologyMod.F90
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ subroutine Infiltration(bounds, num_hydrologyc, filter_hydrologyc, num_urbanc, f
if (lun_pp%ispolygon(col_pp%landunit(c))) then
vdep = (2_r8*iwp_exclvol(c) - iwp_microrel(c)) * (iwp_ddep(c)/iwp_microrel(c))**3_r8 &
+ (2_r8*iwp_microrel(c) - 3_r8*iwp_exclvol(c)) * (iwp_ddep(c)/iwp_microrel(c))**2_r8
phi_eff = min(iwp_subsidence, 0.4) !fix this variable when available to pull from alt calculations
phi_eff = min(iwp_subsidence(c), 0.4) !fix this variable when available to pull from alt calculations
swc = h2osfc(c)/1000_r8 ! convert to m

if (swc >= vdep) then
Expand Down

3 comments on commit 7db2797

@rfiorella
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuckaustin wanted to check in about limiting the subsidence parameter value. I understand the maximum value of 0.4m, but I'm curious if this should be done here or if it should be done in ActiveLayerMod. A couple questions:

  1. Is there a difference in your mind between phi_eff and iwp_subsidence?
  2. If so, is there a desire for iwp_subsidence to have values > 0.4m ever?

@chuckaustin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfiorella I could see this happening in either place. My thoughts about your two questions are:

  1. The only difference between phi_eff and iwp_subsidence is that phi_eff has a maximum value of 0.4.
  2. I could see it going either way. One one hand, it might be nice to keep iwp_subsidence separate, to estimate total subsidence even after microtopography stops changing. It would be one additional variable that we could potentially match against observations someday. On the other hand, it isn't essential, and our methods for estimating subsidence aren't super physically rigorous, so maybe it doesn't have a ton of value.

@rfiorella
Copy link
Collaborator Author

@rfiorella rfiorella commented on 7db2797 May 16, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.