feat(api): update API spec from langfuse/langfuse b3adfc3#1567
Open
langfuse-bot wants to merge 1 commit intomainfrom
Open
feat(api): update API spec from langfuse/langfuse b3adfc3#1567langfuse-bot wants to merge 1 commit intomainfrom
langfuse-bot wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: Experimental PR review
Greptile Summary
This auto-generated PR (from the Fern API definition at
langfuse/langfuse@b3adfc3) adds an optionalcreated_at/createdAtfield to the dataset run item creation API, allowing callers to explicitly set the creation timestamp rather than relying on the server default.created_at: typing.Optional[dt.datetime]parameter toDatasetRunItemsClient.create(),AsyncDatasetRunItemsClient.create(),RawDatasetRunItemsClient.create(), andAsyncRawDatasetRunItemsClient.create().created_atfield to theCreateDatasetRunItemRequestPydantic model with thecreatedAtcamelCase alias.dataset_versionfield (same type, same serialization approach, same documentation style).Confidence Score: 5/5
dataset_versionexactly. There are no logic errors, no serialization concerns beyond what already exists, and no breaking interface changes.Important Files Changed
created_atfield (aliased tocreatedAt) to the Pydantic request model, consistent with existing field conventions.created_at: typing.Optional[dt.datetime]parameter to both sync and asynccreate()methods, and includes it as"createdAt"in the JSON request body — mirrors the same pattern as the existingdataset_versionfield.created_atparameter to both sync and async wrappercreate()methods and passes it through to the raw client — straightforward delegation change.Sequence Diagram
sequenceDiagram participant Caller participant DatasetRunItemsClient participant RawDatasetRunItemsClient participant LangfuseAPI as Langfuse REST API Caller->>DatasetRunItemsClient: create(run_name, dataset_item_id, ..., created_at) DatasetRunItemsClient->>RawDatasetRunItemsClient: create(run_name, dataset_item_id, ..., created_at) RawDatasetRunItemsClient->>LangfuseAPI: POST /api/public/dataset-run-items\n{ runName, datasetItemId, ..., createdAt } LangfuseAPI-->>RawDatasetRunItemsClient: HttpResponse[DatasetRunItem] RawDatasetRunItemsClient-->>DatasetRunItemsClient: HttpResponse[DatasetRunItem] DatasetRunItemsClient-->>Caller: DatasetRunItemLast reviewed commit: "feat(api): update AP..."