fix(observe): Handle asyncio.CancelledError in exception blocks#1566
Merged
hassiebp merged 2 commits intolangfuse:mainfrom Mar 19, 2026
Merged
fix(observe): Handle asyncio.CancelledError in exception blocks#1566hassiebp merged 2 commits intolangfuse:mainfrom
hassiebp merged 2 commits intolangfuse:mainfrom
Conversation
jinohkang-theori
force-pushed
the
patch-1
branch
3 times, most recently
from
ba4506c to
a706ed4
Compare
Fixes langfuse/langfuse#12650 This catches and records the async task being cancelled—either directly or because it timed out—which will raise an asyncio.CancelledError to stop execution. Also fix sync wrappers as well. Note that asyncio.CancelledError can cross async-sync boundaries, such as `run_coroutine_threadsafe().result()` or a sync helper function that re-raises cancellation that was previously suppressed/deferred.
jinohkang-theori
force-pushed
the
patch-1
branch
from
a706ed4 to
2f19519
Compare
Contributor
|
Thanks a lot for your contribution, @jinohkang-theori ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes langfuse/langfuse#12650
This catches and records the async task being cancelled—either directly or because it timed out—which will raise an asyncio.CancelledError to stop execution.
Also fix sync wrappers as well. Note that asyncio.CancelledError can cross async-sync boundaries, such as
run_coroutine_threadsafe().result()or a sync helper function that re-raises cancellation that was previously suppressed/deferred.