fix(openai): handle parsed_n non integer

[hassiebp]

Important

Fixes condition in _get_langfuse_data_from_kwargs to ensure parsed_n is an integer before comparison, preventing errors with non-integer values.

• Behavior:
  • Fixes condition in _get_langfuse_data_from_kwargs in langfuse/openai.py to check if parsed_n is an integer before comparing it to 1.
  • Prevents errors when parsed_n is not an integer.

^{This description was created by for b8de64b. You can customize this summary. It will automatically update as commits are pushed.}

Disclaimer: Experimental PR review

Greptile Overview

Greptile Summary

Added type validation for the n parameter to prevent TypeError when comparing non-integer values.

• Added isinstance(parsed_n, int) check before comparing parsed_n > 1 to handle edge cases where the OpenAI SDK passes non-integer values
• Prevents potential runtime errors when comparing non-numeric types with integers
• Follows defensive programming pattern by validating types before operations

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The change is a simple defensive type check that prevents potential runtime errors. The logic is sound and follows best practices for type validation before comparison operations. The change is minimal, focused, and doesn't alter the core functionality.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
langfuse/openai.py	4/5	Added type check to prevent comparison errors when n parameter is non-integer; defensive programming improvement

Sequence Diagram

sequenceDiagram
    participant Client
    participant _get_langfuse_data_from_kwargs
    participant modelParameters
    
    Client->>_get_langfuse_data_from_kwargs: Call with kwargs containing 'n' parameter
    _get_langfuse_data_from_kwargs->>_get_langfuse_data_from_kwargs: Extract parsed_n from kwargs.get("n", 1)
    
    alt parsed_n is not None
        _get_langfuse_data_from_kwargs->>_get_langfuse_data_from_kwargs: Check isinstance(parsed_n, int)
        
        alt parsed_n is integer AND parsed_n > 1
            _get_langfuse_data_from_kwargs->>modelParameters: Add n parameter to modelParameters
        else parsed_n is not integer OR parsed_n <= 1
            _get_langfuse_data_from_kwargs->>_get_langfuse_data_from_kwargs: Skip adding n to modelParameters
        end
    end
    
    _get_langfuse_data_from_kwargs->>Client: Return langfuse data with modelParameters

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}