Conversation
Contributor
There was a problem hiding this comment.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+302
to
+310
| async_public_api_client = AsyncFernLangfuse( | ||
| base_url=self.base_url, | ||
| username=public_key, | ||
| password=secret_key, | ||
| x_langfuse_sdk_name="python", | ||
| x_langfuse_sdk_version=version, | ||
| x_langfuse_public_key=public_key, | ||
| timeout=timeout, | ||
| ) |
Contributor
There was a problem hiding this comment.
logic: The async client is instantiated without an httpx_client, while the sync client uses the shared httpx_client. This could lead to connection pooling issues since the async client will create its own connection pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add asynchronous API client
AsyncFernLangfusetoLangfuseclass for non-blocking operations.AsyncFernLangfusetoLangfuseclass inclient.pyfor asynchronous API operations.async_public_api_clientinLangfuse.__init__()and assign toself.async_api.AsyncFernLangfusefromlangfuse.api.client.This description was created by
for a1f7f14. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Added asynchronous API client capabilities to the Langfuse Python SDK while maintaining backward compatibility with the existing synchronous client.
AsyncFernLangfuseclient in/langfuse/client.pyfor non-blocking API callsself.apiand legacyself.clientfor backward compatibilityself.async_apiproperty to access new async client functionality