fix(openai): handle usage object without mutation#1101
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This was
linked to
issues
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes mutation issue in
_parse_usageby copying the usage dictionary inopenai.py._parse_usageinopenai.pyto copy the usage dictionary to prevent mutation of the original object.test_openai.pyto check for substring presence in model names.This description was created by
for 979ce0b. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR modifies the OpenAI usage object handling in langfuse-python to prevent unintended mutations of the original usage data during token detail processing.
_parse_usageinlangfuse/openai.pyto create a copy of the usage dictionary before processing