Skip to content

Conversation

@arun-geek
Copy link
Contributor

  1. Currently , Removes tag one by one by passing it in as list argument to remove_tags
  2. Can create and pass the list at once instead of having it to create a list of just on object and passing it downstream remove_tags

1. Currently , Removes tag one by one by passing it in as list argument to remove_tags
2. Can create and pass the list at once instead of having it to create a list of just on object and passing it downstream remove_tags
@arun-geek arun-geek requested a review from eyurtsev as a code owner October 26, 2025 00:58
@github-actions github-actions bot added core Related to the package `langchain-core` refactor labels Oct 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2025

CodSpeed Performance Report

Merging #33673 will not alter performance

Comparing arun-geek:core (a915611) with master (f3d7152)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched
⏩ 21 skipped1

Footnotes

  1. 21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior between these differs in edge cases. If this change is motivated by a material performance issue, could you open an issue describing it? Open to re-opening the PR if it's solving a problem.

@ccurme ccurme closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Related to the package `langchain-core` refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants