Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community/Partner: Adding Azure community and partner user agent to better track usage in Python #29561

Merged
merged 32 commits into from
Feb 7, 2025

Conversation

marlenezw
Copy link
Contributor

  • This pull request includes various changes to add a user_agent parameter to Azure OpenAI, Azure Search and Whisper in the Community and Partner packages. This helps in identifying the source of API requests so we can better track usage and help support the community better. I will also be adding the user_agent to the new langchain-azure repo as well.

  • No issue connected or updated dependencies.

  • Utilises existing tests and docs

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 11:24pm

@dosubot dosubot bot added the community Related to langchain-community label Feb 3, 2025
@marlenezw
Copy link
Contributor Author

@sinedied @santiagxf I need to run linting and tests but could you both have a look. Will add to the langchain-azure package as well.

@santiagxf
Copy link
Contributor

Should we move Azure clases from community to official and mark them deprecated?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 4, 2025
@marlenezw
Copy link
Contributor Author

marlenezw commented Feb 4, 2025

@santiagxf I think there are certain classes, for example the AzureOpenAI class within OpenAI, that I think is useful to leave as is. My feeling is that we should also give people a depreciation timeline so they know to transition over. I'd also like to compare the numbers for a bit to see if the move makes any difference at all, so maybe a few weeks or so of data could be helpful! What are your thoughts?

@santiagxf
Copy link
Contributor

santiagxf commented Feb 4, 2025

I meant the ones on the Community package (langchain-community). Indeed the ones on partner packages should remain! Community should only contain the code contributed by community.

@marlenezw
Copy link
Contributor Author

That makes sense! Yes, for the community packages I definitely think we should remove the classes when we are ready to depreciate it completely. @santiagxf do you think we should set a final depreciation date and add this as a message in the code? I can create a seperate PR for it in the mean time.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 5, 2025
Copy link

vercel bot commented Feb 7, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@marlenezw
Copy link
Contributor Author

Hi @efriis or @ccurme, this PR is ready for review! I've run tests and things are working as expected.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 7, 2025
@efriis efriis enabled auto-merge (squash) February 7, 2025 23:27
@efriis efriis merged commit 4fa3ef0 into langchain-ai:master Feb 7, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants