Get by ids #25
Open
Get by ids #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
requested review from
tylerhutcherson and
bsbodden
and removed request for
tylerhutcherson
|
|
||
| result_docs = [] | ||
| for key in ids: | ||
| doc_dict = self.index.client.hgetall( |
There was a problem hiding this comment.
Should use a pipeline operation for this with transaciton=False
There was a problem hiding this comment.
@tylerhutcherson What do you think about these changes?
bsbodden
requested changes
Feb 13, 2025
| # Create a unique index name for testing | ||
| index_name = f"test_index_{str(ULID())}" | ||
|
|
||
| texts = ["foo", "bar", "baz"] |
There was a problem hiding this comment.
Here's where there is a conceptual misunderstanding... You have keys as keys = ["a", "b", "c"] but those are not the keys; they are the IDs! Where you construct the ids below, those are actually the Redis Keys.
What this PR should do is pass ids and internally grab the prefix from the index to construct the keys that will be retrieved from Redis. cc @tylerhutcherson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the get_by_ids method in the VectorStore class, along with its unit and integration tests. @bsbodden @efriis @tylerhutcherson @baskaryan @ccurme