Move state into the same file as graph #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran the example following the README, I was unable to get it running, as it kept erroring that the graph file could not see the state file. It seemed as if it didn't install it properly as an editable app, or other configuration was needed with the python path. I don't use poetry regularly, so wasnt sure how to make poetry happy.
However, I found a nice quick fix: just move everything into one file! No relative imports needed. Obviously this fix isn't sustainable once you do rightly want a multi-file repo, but I thought I'd send the PR since it was the quickest fix I found to getting this working.