test: lock exact file-version wire contracts - #8019
Draft
Xuanwo wants to merge 2 commits into
Draft
Conversation
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2/12 of #7877. Depends on #7879.
This is an independently reviewable step toward the final layout demonstrated in #7979.
Before moving reader and writer ownership, this PR locks the persisted contracts for V1, V2.0, V2.1, and V2.2 with checked-in fixtures. The assertions cover manifest identity,
DataFileidentity, standard footer numbers, embedded footer numbers, schema, and representative reads.The V2.0 fixture explicitly preserves the intentional split between the standard footer
(0, 3)and embedded footer(2, 0). No production dispatch changes are included.Validation:
cargo test -p lance-file compatibility_testscargo fmt --all -- --check