feat(blob): distribute blob sidecar keys with reversed binary ids#6060
Merged
feat(blob): distribute blob sidecar keys with reversed binary ids#6060
Conversation
Contributor
PR Review: feat(blob): distribute blob sidecar keys with reversed binary idsNo P0 or P1 issues found. This is a clean, well-scoped change. The approach is sound: One minor observation (not blocking):
LGTM. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
BubbleCal
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR accepts suggestion from @jackye1995.
data_file_keyalready randomizes distribution across data files, but sidecars under a single data file still used sequential-looking names. Reversed-bit binary names improve prefix fan-out for this local sequence without introducing compatibility constraints (this version is unreleased).{:08x}) to binary ({:032b})blob_id.reverse_bits()so early sequential IDs spread quickly across object-store key prefixesParts of this PR were drafted with assistance from Codex (with
gpt-5.3-codex) and fully reviewed and edited by me. I take full responsibility for all changes.