fix: bitmap iterator exhaustion in mask_to_offset_ranges#6046
Open
wkalt wants to merge 1 commit intolance-format:mainfrom
Open
fix: bitmap iterator exhaustion in mask_to_offset_ranges#6046wkalt wants to merge 1 commit intolance-format:mainfrom
wkalt wants to merge 1 commit intolance-format:mainfrom
Conversation
…egment sequences In mask_to_offset_ranges, the RangeWithBitmap case advanced the bitmap iterator using a global offset (addr - range.start + offset_start) instead of a range-local position (addr - range.start). When a RangeWithBitmap segment appeared after other segments (offset_start > 0), the iterator was advanced past its end, causing a panic. The fix separates range-local iteration from the final offset calculation: iterate the bitmap using position_in_range, then add offset_start at the end. Includes an integration test that reproduces the panic through the user-facing API: write 2 fragments with stable row IDs, delete some rows, compact, create a BTree index, then run a filtered scan. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
ReviewClean, correct fix. No P0/P1 issues. The bitmap in Test coverage is good — the integration test reproduces the exact multi-segment scenario through the public API. LGTM. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mask_to_offset_ranges, the RangeWithBitmap case advanced the bitmap iterator using a global offset (addr - range.start + offset_start) instead of a range-local position (addr - range.start). When a RangeWithBitmap segment appeared after other segments (offset_start > 0), the iterator was advanced past its end, causing a panic.
The fix separates range-local iteration from the final offset calculation: iterate the bitmap using position_in_range, then add offset_start at the end.
Includes an integration test that reproduces the panic through the user-facing API: write 2 fragments with stable row IDs, delete some rows, compact, create a BTree index, then run a filtered scan.