refactor: collapse redundant branch in add_columns_from transform#5198
Open
LuciferYang wants to merge 1 commit into
Open
refactor: collapse redundant branch in add_columns_from transform#5198LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
The elif (pa.Table | dict) and else arms in _wrap_transform both assigned new_cols = result, so the isinstance check was dead. Collapse to a single else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
add_columns_from, the callable-transform branch checked whether the transform's result was apa.Tableordictand assignednew_cols = result, then theelsedid exactly the same thing. Theisinstancecheck had no effect — both arms were identical — and the result is normalized further down regardless.Collapsed the two arms into a single
else. No behavior change; theRecordBatchcase above it is untouched.