fix: use RuntimeWarning for empty write results in datasink#5193
Open
LuciferYang wants to merge 1 commit into
Open
fix: use RuntimeWarning for empty write results in datasink#5193LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
on_write_complete flagged empty write results with DeprecationWarning, but nothing is deprecated; it is an operational/empty-input condition. Use RuntimeWarning so it is not filtered by deprecation suppressors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LanceDatasink.on_write_completewarns and skips the commit when it gets no write results back, but it raised that as aDeprecationWarning. Nothing is actually deprecated — it's an empty-input / operational condition — andDeprecationWarningis hidden by default outside__main__, so the warning meant to flag "your write produced nothing to commit" was effectively invisible.Both empty-result warnings now use
RuntimeWarning, which fits the situation and shows up under the default filters. The messages and call sites are otherwise unchanged.Added unit tests for both branches — the empty list, and the
write_returnswrapper unwrapping to empty — each assertingRuntimeWarningand that noDeprecationWarningis raised.